Fix heal update #137
Merged
Fix heal update #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwarnicke
reviewed
Mar 24, 2021
| connect.NewServer( | ||
| ctx, | ||
| func(ctx context.Context, cc grpc.ClientConnInterface) networkservice.NetworkServiceClient { | ||
| return client.NewClient(ctx, | ||
| cc, | ||
| client.WithName(name), | ||
| client.WithHeal(addressof.NetworkServiceClient(adapters.NewServerToClient(rv))), | ||
| heal.NewClient(ctx, cc), |
There was a problem hiding this comment.
Isn't heal built into client.NewClient? If not... why not?
There was a problem hiding this comment.
Yep, it is already there. My mistake
There was a problem hiding this comment.
Please do check further downstream as well. When I attempted this fix in my local repo, the cmd-forwarder-vpp stopped working... so we may need to chase down issues as this trickles downstream (although I could have also just gotten my local repo into an odd state).
Signed-off-by: Artem Belov <artem.belov@xored.com>
artem-belov
force-pushed
the
pr-fix-heal-update
branch
from
f78bb3b to
8280238
Compare
haiodo
approved these changes
Mar 24, 2021
haiodo
pushed a commit
that referenced
this pull request
Mar 24, 2021
* Update go.mod and go.sum to latest version from networkservicemesh/sdk@master networkservicemesh/sdk#786 networkservicemesh/sdk PR link: networkservicemesh/sdk#786 networkservicemesh/sdk commit message: commit a9754c798b744b599e0420e29ee84e0e176c8807 Author: Network Service Mesh Bot <60070799+nsmbot@users.noreply.github.com> Date: Tue Mar 23 10:24:22 2021 -0500 Update from update/networkservicemesh/api Signed-off-by: NSMBot <nsmbot@networkservicmesh.io> * Fix heal update (#137) Signed-off-by: Artem Belov <artem.belov@xored.com> Co-authored-by: NSMBot <nsmbot@networkservicmesh.io> Co-authored-by: Artem Belov <artem.belov@xored.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artem Belov artem.belov@xored.com